Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1321523002: Add a task to partially resolve a compilation unit (Closed)

Created:
5 years, 3 months ago by Brian Wilkerson
Modified:
5 years, 3 months ago
Reviewers:
Leaf, Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -12 lines) Patch
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 6 chunks +130 lines, -12 lines 2 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +69 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
As noted in the TODO comment, this current does too much work, so performance is ...
5 years, 3 months ago (2015-08-26 16:55:24 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/1321523002/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1321523002/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode357 pkg/analyzer/lib/src/task/dart.dart:357: * TODO(brianwilkerson) Rename this to RESOLVED_UNIT_5. Why not ...
5 years, 3 months ago (2015-08-26 17:05:23 UTC) #3
Leaf
lgtm
5 years, 3 months ago (2015-08-26 18:01:16 UTC) #4
Brian Wilkerson
Committed patchset #1 (id:1) manually as c3b12a65ba6a86c8543c8ba8232a785c09cc431e (presubmit successful).
5 years, 3 months ago (2015-08-26 18:22:07 UTC) #5
Brian Wilkerson
5 years, 3 months ago (2015-08-26 20:33:53 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1321523002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1321523002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:357: * TODO(brianwilkerson) Rename this to
RESOLVED_UNIT_5.
No good reason (any more). Done.

Powered by Google App Engine
This is Rietveld 408576698