Extend the immutable collections test to the new API. Make *Members return immutable collections. A…

Extend the immutable collections test to the new API. Make *Members return immutable collections. Add missing metadata property for SyntheticSetterParameter.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31675

[siva, 2014-01-09 19:29:49]

lgtm

https://codereview.chromium.org/132133003/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/132133003/diff/1/runtime/lib/mirrors_impl.dar...
runtime/lib/mirrors_impl.dart:1106: // }
Why are we carrying this commented out code?

Maybe you should add a comment here explaining why the code needs to be
commented out, also I am not sure about the style guide here, would be
preferable to use
/**
 * Reason for commenting out.
 ....
 ....
 */

[rmacnak, 2014-01-09 20:38:07]

https://codereview.chromium.org/132133003/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/132133003/diff/1/runtime/lib/mirrors_impl.dar...
runtime/lib/mirrors_impl.dart:1106: // }
On 2014/01/09 19:29:49, siva wrote:
> Why are we carrying this commented out code?
> 
> Maybe you should add a comment here explaining why the code needs to be
> commented out, also I am not sure about the style guide here, would be
> preferable to use
> /**
>  * Reason for commenting out.
>  ....
>  ....
>  */

This was for behavior that wasn't agreed to. I'll just take it out.

[rmacnak, 2014-01-09 20:38:39]

Committed patchset #3 manually as r31675 (presubmit successful).

[vsm, 2014-01-10 23:44:59]

On 2014/01/09 20:38:39, Ryan Macnak wrote:
> Committed patchset #3 manually as r31675 (presubmit successful).

Ryan, this test is timing out on all the dartium debug bots (instead of expected
fail).  Can you please take a look?  Should we just skip this test on Dartium?

[rmacnak, 2014-01-10 23:55:10]

On 2014/01/10 23:44:59, vsm wrote:
> On 2014/01/09 20:38:39, Ryan Macnak wrote:
> > Committed patchset #3 manually as r31675 (presubmit successful).
> 
> Ryan, this test is timing out on all the dartium debug bots (instead of
expected
> fail).  Can you please take a look?  Should we just skip this test on Dartium?

I'll skip it on Dartium for now and look into sharding it.