Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1321013006: dart2js cps: Remove some uses of giveup. (Closed)

Created:
5 years, 3 months ago by karlklose
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 3 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 3 months ago (2015-09-03 13:32:07 UTC) #1
Kevin Millikin (Google)
lgtm
5 years, 3 months ago (2015-09-04 08:09:18 UTC) #2
karlklose
5 years, 3 months ago (2015-09-04 08:20:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
42e374d41da8bb371584bd0e664abdf9961bf653 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698