Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 1320913002: dart2js: Add test to compile empty main without any libraries. (Closed)

Created:
5 years, 3 months ago by karlklose
Modified:
5 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Add test to compile empty main without any libraries. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/28e25dc4e6ed123267466591e4d255c6ad8e31b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
A tests/compiler/dart2js/compile_with_empty_libraries_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 4 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 3 months ago (2015-08-27 13:41:06 UTC) #1
Johnni Winther
lgtm
5 years, 3 months ago (2015-08-28 10:55:22 UTC) #2
karlklose
5 years, 3 months ago (2015-08-28 10:57:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
28e25dc4e6ed123267466591e4d255c6ad8e31b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698