Issue 1320793005: Fix analyzer problems in object.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1320793005: Fix analyzer problems in object.dart. (Closed)

Created:
5 years, 3 months ago by turnidge

Modified:
5 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix analyzer problems in object.dart. BUG= Committed: https://github.com/dart-lang/sdk/commit/5dcad9482ddf4daae5e298a69aaff0bae13f3749

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
	M	runtime/observatory/lib/src/service/object.dart	View		6 chunks	+17 lines, -10 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

turnidge

Committed patchset #1 (id:1) manually as 5dcad9482ddf4daae5e298a69aaff0bae13f3749 (presubmit successful).

5 years, 3 months ago (2015-09-09 16:56:40 UTC) #3

Ivan Posva

5 years, 3 months ago (2015-09-09 17:09:27 UTC) #4

Message was sent while issue was closed.

LGTM -ip

https://codereview.chromium.org/1320793005/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1320793005/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:1511: SourceLocation loc =
bpt.location;
Was this change still needed after adding the Location interface?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages