Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320533004: Switch from unittest to test. (Closed)

Created:
5 years, 3 months ago by Bob Nystrom
Modified:
5 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/markdown.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch from unittest to test. R=nweiz@google.com Committed: 079ea42c740a459557391a35d0badc6a302f5ec2

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -5 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 4 comments Download
M CHANGELOG.md View 1 chunk +7 lines, -0 lines 0 comments Download
A pubspec.lock View 1 chunk +131 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -2 lines 2 comments Download
M test/markdown_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/util.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
5 years, 3 months ago (2015-09-01 19:45:23 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1320533004/diff/1/.gitignore File .gitignore (left): https://codereview.chromium.org/1320533004/diff/1/.gitignore#oldcode5 .gitignore:5: pubspec.lock I'm not a big fan of checking ...
5 years, 3 months ago (2015-09-01 20:03:42 UTC) #3
Bob Nystrom
Committed patchset #1 (id:1) manually as 079ea42c740a459557391a35d0badc6a302f5ec2 (presubmit successful).
5 years, 3 months ago (2015-09-01 20:13:28 UTC) #4
Bob Nystrom
5 years, 3 months ago (2015-09-01 20:13:36 UTC) #5
Message was sent while issue was closed. 
Thanks!

https://codereview.chromium.org/1320533004/diff/1/.gitignore
File .gitignore (left):

https://codereview.chromium.org/1320533004/diff/1/.gitignore#oldcode5
.gitignore:5: pubspec.lock
On 2015/09/01 20:03:42, nweiz wrote:
> I'm not a big fan of checking in pubspecs for library packages—I don't think
you
> want everyone running tests against the same package versions, and it creates
> extra churn when you update versions—but YMMV.

Yeah, I do think it's important to test against different versions, but I don't
like the idea of contributors being unwitting guinea pigs for that. I like
reproducibility.

https://codereview.chromium.org/1320533004/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1320533004/diff/1/.gitignore#newcode4
.gitignore:4: packages
On 2015/09/01 20:03:42, nweiz wrote:
> Add .packages.

Look up.

https://codereview.chromium.org/1320533004/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1320533004/diff/1/pubspec.yaml#newcode9
pubspec.yaml:9: test: '^0.12.4+1'
On 2015/09/01 20:03:42, nweiz wrote:
> If you're using "^" constraints, make the SDK dependency >=1.8.0.

Done.

Powered by Google App Engine
This is Rietveld 408576698