Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 1320523003: Make a bunch of API changes. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/oauth2.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make a bunch of API changes. These are generally very small; some of them are breaking, but it'll be easy for users to change over to the new APIs. The new APIs generally bring the package more in line with the OAuth 2.0 spec. The old API was narrowly focused on specifically connecting to Google's servers using an authorization code grant; the new APIs should be more flexible and consistent with more grant types. R=rnystrom@google.com Committed: https://github.com/dart-lang/oauth2/commit/45f3628ff045d625daccefce333fbdbd5fd1969c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -93 lines) Patch
M CHANGELOG.md View 1 chunk +32 lines, -0 lines 0 comments Download
M README.md View 1 chunk +4 lines, -2 lines 0 comments Download
M lib/src/authorization_code_grant.dart View 4 chunks +45 lines, -14 lines 0 comments Download
M lib/src/client.dart View 3 chunks +18 lines, -8 lines 2 comments Download
M lib/src/credentials.dart View 5 chunks +46 lines, -29 lines 0 comments Download
M lib/src/handle_access_token_response.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/authorization_code_grant_test.dart View 4 chunks +71 lines, -5 lines 0 comments Download
M test/client_test.dart View 10 chunks +38 lines, -13 lines 0 comments Download
M test/credentials_test.dart View 6 chunks +135 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 4 months ago (2015-08-25 23:23:02 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1320523003/diff/1/lib/src/client.dart File lib/src/client.dart (right): https://codereview.chromium.org/1320523003/diff/1/lib/src/client.dart#newcode86 lib/src/client.dart:86: /// Thrwos an [ArgumentError] if [secret] is passed ...
5 years, 3 months ago (2015-08-26 16:52:44 UTC) #2
nweiz
Committed patchset #1 (id:1) manually as 45f3628ff045d625daccefce333fbdbd5fd1969c (presubmit successful).
5 years, 3 months ago (2015-08-26 20:47:22 UTC) #3
nweiz
5 years, 3 months ago (2015-08-26 20:47:28 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/1320523003/diff/1/lib/src/client.dart
File lib/src/client.dart (right):

https://codereview.chromium.org/1320523003/diff/1/lib/src/client.dart#newcode86
lib/src/client.dart:86: /// Thrwos an [ArgumentError] if [secret] is passed
without [identifier].
On 2015/08/26 16:52:44, Bob Nystrom wrote:
> "Throws"

Done.

Powered by Google App Engine
This is Rietveld 408576698