Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1320423004: Document the fact that SendPort.send() dispatches messages immediately. (Closed)

Created:
5 years, 3 months ago by Paul Berry
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Document the fact that SendPort.send() dispatches messages immediately. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/3069c86af48c5d25f91b52e7d2687da06da4ff1e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revised wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M sdk/lib/isolate/isolate.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Paul Berry
5 years, 3 months ago (2015-08-31 18:20:10 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/1320423004/diff/1/sdk/lib/isolate/isolate.dart File sdk/lib/isolate/isolate.dart (right): https://codereview.chromium.org/1320423004/diff/1/sdk/lib/isolate/isolate.dart#newcode490 sdk/lib/isolate/isolate.dart:490: * loop, provided that the receiver is running in ...
5 years, 3 months ago (2015-08-31 19:45:20 UTC) #3
Paul Berry
https://codereview.chromium.org/1320423004/diff/1/sdk/lib/isolate/isolate.dart File sdk/lib/isolate/isolate.dart (right): https://codereview.chromium.org/1320423004/diff/1/sdk/lib/isolate/isolate.dart#newcode490 sdk/lib/isolate/isolate.dart:490: * loop, provided that the receiver is running in ...
5 years, 3 months ago (2015-08-31 19:48:53 UTC) #4
Lasse Reichstein Nielsen
lgtm
5 years, 3 months ago (2015-08-31 19:57:28 UTC) #5
Paul Berry
5 years, 3 months ago (2015-08-31 21:13:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3069c86af48c5d25f91b52e7d2687da06da4ff1e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698