Issue 1320273003: Clean up and improve some of the task tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1320273003: Clean up and improve some of the task tests (Closed)

Created:
5 years, 3 months ago by Brian Wilkerson

Modified:
5 years, 3 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+269 lines, -235 lines)			Patch
M	pkg/analyzer/test/src/context/abstract_context.dart	View	1 chunk	+10 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	84 chunks	+245 lines, -214 lines	0 comments	Download
M	pkg/analyzer/test/src/task/html_test.dart	View	11 chunks	+14 lines, -19 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

Unless you can think of a reason for keeping them, I'm also tempted to remove ...

5 years, 3 months ago (2015-08-31 22:17:04 UTC) #2

scheglov

LGTM! > Unless you can think of a reason for keeping them, I'm also tempted ...

5 years, 3 months ago (2015-08-31 22:20:41 UTC) #3

Brian Wilkerson

5 years, 3 months ago (2015-08-31 23:55:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
17dbad18e9d9e811a4f035b9ac52de4b98485fb2 (presubmit successful).