Issue 1320143002: dart2js: A bit more inlining of static invocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1320143002: dart2js: A bit more inlining of static invocations. (Closed)

Created:
5 years, 3 months ago by Kevin Millikin (Google)

Modified:
5 years, 3 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: A bit more inlining of static invocations. Allow is and is! checks, == and !=, parameter references, and literals. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/d074fa69b75ba1725252232ddd80ce31a50fe92b

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		1 chunk	+20 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kevin Millikin (Google)

This pattern matching predicate doesn't really scale but I wanted to get a bit more ...

5 years, 3 months ago (2015-08-28 14:02:30 UTC) #1

asgerf

lgtm https://codereview.chromium.org/1320143002/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right): https://codereview.chromium.org/1320143002/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart#newcode1713 pkg/compiler/lib/src/cps_ir/type_propagation.dart:1713: // predicate. This comment is a tautology, it ...

5 years, 3 months ago (2015-08-28 14:09:27 UTC) #4

Kevin Millikin (Google)

5 years, 3 months ago (2015-08-28 14:14:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d074fa69b75ba1725252232ddd80ce31a50fe92b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages