Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1320023008: Refactor the io resource classes (Closed)

Created:
5 years, 3 months ago by ricow1
Modified:
5 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor the io resource classes Move stopwatch so that we will only ever need one instance Add utility functions for doing reads and writes The only functional change here is that I say that an except is a read of one byte, which also updates the readcount. I think this is just as correct as what we did before. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/c6918fb126acd77ea38e6dd049bf459e53a4e808

Patch Set 1 #

Patch Set 2 : remove todo #

Total comments: 2

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -38 lines) Patch
M runtime/bin/socket_patch.dart View 6 chunks +6 lines, -14 lines 0 comments Download
M runtime/observatory/tests/service/tcp_socket_service_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/file_impl.dart View 10 chunks +10 lines, -20 lines 0 comments Download
M sdk/lib/io/io_resource_info.dart View 1 2 2 chunks +23 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ricow1
5 years, 3 months ago (2015-09-08 12:51:34 UTC) #2
Søren Gjesse
https://codereview.chromium.org/1320023008/diff/20001/sdk/lib/io/io_resource_info.dart File sdk/lib/io/io_resource_info.dart (right): https://codereview.chromium.org/1320023008/diff/20001/sdk/lib/io/io_resource_info.dart#newcode57 sdk/lib/io/io_resource_info.dart:57: void didRead() { Maybe just implement like this: void ...
5 years, 3 months ago (2015-09-09 07:12:21 UTC) #3
Søren Gjesse
lgtm
5 years, 3 months ago (2015-09-09 07:12:26 UTC) #4
ricow1
thanks https://codereview.chromium.org/1320023008/diff/20001/sdk/lib/io/io_resource_info.dart File sdk/lib/io/io_resource_info.dart (right): https://codereview.chromium.org/1320023008/diff/20001/sdk/lib/io/io_resource_info.dart#newcode57 sdk/lib/io/io_resource_info.dart:57: void didRead() { On 2015/09/09 07:12:21, Søren Gjesse ...
5 years, 3 months ago (2015-09-09 07:14:24 UTC) #5
ricow1
5 years, 3 months ago (2015-09-09 07:18:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c6918fb126acd77ea38e6dd049bf459e53a4e808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698