Allow root level requests in the vm service.

Allow root level requests in the vm service.

Move /cpu to the root level.

Move PostReply to the command handlers.  This will allow command
handlers to reply asynchronously (by delegating elsewhere) if they
need to.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31849

[Cutch, 2014-01-09 23:03:23]

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/json_stream.cc
File runtime/vm/json_stream.cc (right):

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/json_stream.c...
runtime/vm/json_stream.cc:186: void JSONStream::SetReplyPort(Dart_Port port) {
Style guide says this should be set_reply_port

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/json_stream.h
File runtime/vm/json_stream.h (right):

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/json_stream.h...
runtime/vm/json_stream.h:34: Dart_Port reply_port() const { return reply_port_;
}
Should we be storing the port to reply to on the JSON stream?

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/service.cc#ne...
runtime/vm/service.cc:23: typedef void (*IsolateMessageHandler)(Isolate*
isolate, JSONStream* stream);
Why not have the handler functions return true to indicate that the stream
should be posted for reply? This should move all of the PostReply calls into
just one place. If the handler returns false it means the handler has forwarded
the message for asynchronous handling and will post the reply itself.

[turnidge, 2014-01-15 20:21:04]

PTAL

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/json_stream.cc
File runtime/vm/json_stream.cc (right):

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/json_stream.c...
runtime/vm/json_stream.cc:186: void JSONStream::SetReplyPort(Dart_Port port) {
On 2014/01/09 23:03:23, Cutch wrote:
> Style guide says this should be set_reply_port

Ok.

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/json_stream.h
File runtime/vm/json_stream.h (right):

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/json_stream.h...
runtime/vm/json_stream.h:34: Dart_Port reply_port() const { return reply_port_;
}
On 2014/01/09 23:03:23, Cutch wrote:
> Should we be storing the port to reply to on the JSON stream?

Discussed offline - we will fix later.

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/131973007/diff/30003/runtime/vm/service.cc#ne...
runtime/vm/service.cc:23: typedef void (*IsolateMessageHandler)(Isolate*
isolate, JSONStream* stream);
On 2014/01/09 23:03:23, Cutch wrote:
> Why not have the handler functions return true to indicate that the stream
> should be posted for reply? This should move all of the PostReply calls into
> just one place. If the handler returns false it means the handler has
forwarded
> the message for asynchronous handling and will post the reply itself.

Done.

[Cutch, 2014-01-15 20:41:07]

lgtm

[turnidge, 2014-01-15 20:45:49]

Committed patchset #7 manually as r31849 (presubmit successful).