Handle cycles when infering static variables

Handle cycles when infering static variables

R=leafp@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/fbd968c8e59594d75985c07ae8e38d959c53ba8d

[Brian Wilkerson, 2015-08-31 19:39:36]

brianwilkerson@google.com changed reviewers:
+ leafp@google.com, paulberry@google.com

[Brian Wilkerson, 2015-08-31 19:39:37]

This might be controversial, but I think we should just not infer types for
variables involved in a cycle. If you think we need to do something better,
let's discuss the approach off-line.

[Paul Berry, 2015-08-31 19:44:23]

lgtm, but I'd like to hear Leaf's opinion before committing.

[Leaf, 2015-08-31 21:07:03]

lgtm.  We can revisit the cycle issue if necessary.

https://codereview.chromium.org/1319703003/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1319703003/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2609: // warrent the extra effort.
warrent -> warrant

[Brian Wilkerson, 2015-08-31 21:27:48]

https://codereview.chromium.org/1319703003/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1319703003/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2609: // warrent the extra effort.
Thanks! I really miss spell checking :-(

[Brian Wilkerson, 2015-08-31 21:28:03]

Committed patchset #1 (id:1) manually as
fbd968c8e59594d75985c07ae8e38d959c53ba8d (presubmit successful).