Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13190014: Optimizes 'as' operation in similar way as 'instanceof': collect type feedback in unoptimized mode… (Closed)

Created:
7 years, 8 months ago by srdjan
Modified:
7 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, Vyacheslav Egorov (Google), Kevin Millikin (Google)
Visibility:
Public.

Description

Optimizes 'as' operation in similar way as 'instanceof': collect type feedback in unoptimized mode and try to convert it to a simple classcheck in optimized code. Committed: https://code.google.com/p/dart/source/detail?r=20783

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -61 lines) Patch
M runtime/lib/object.cc View 1 3 chunks +62 lines, -1 line 0 comments Download
M runtime/lib/object_patch.dart View 1 chunk +9 lines, -5 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 3 chunks +59 lines, -21 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 2 chunks +44 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/type_cast_vm_test.dart View 1 2 3 4 5 chunks +22 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
srdjan
7 years, 8 months ago (2013-04-01 20:01:01 UTC) #1
regis
https://codereview.chromium.org/13190014/diff/8001/tests/language/type_cast_vm_test.dart File tests/language/type_cast_vm_test.dart (right): https://codereview.chromium.org/13190014/diff/8001/tests/language/type_cast_vm_test.dart#newcode22 tests/language/type_cast_vm_test.dart:22: } Why is the error position not reported and ...
7 years, 8 months ago (2013-04-01 20:28:49 UTC) #2
srdjan
https://codereview.chromium.org/13190014/diff/8001/tests/language/type_cast_vm_test.dart File tests/language/type_cast_vm_test.dart (right): https://codereview.chromium.org/13190014/diff/8001/tests/language/type_cast_vm_test.dart#newcode22 tests/language/type_cast_vm_test.dart:22: } On 2013/04/01 20:28:49, regis wrote: > Why is ...
7 years, 8 months ago (2013-04-01 21:47:17 UTC) #3
regis
LGTM
7 years, 8 months ago (2013-04-02 00:10:54 UTC) #4
srdjan
7 years, 8 months ago (2013-04-02 15:30:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r20783 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698