Issue 1318603008: Add new SpanScanner.eager().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1318603008: Add new SpanScanner.eager(). (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/string_scanner@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add new SpanScanner.eager(). This is more efficient for uses like the YAML parser, which uses the current line and especially column information frequently while parsing a file. R=rnystrom@google.com Committed: https://github.com/dart-lang/string_scanner/commit/ad926d6c2840dd1248f07ed9c0b640f2620d2449

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -66 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	lib/src/eager_span_scanner.dart	View	3 chunks	+18 lines, -28 lines	0 comments	Download
M	lib/src/line_scanner.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/src/span_scanner.dart	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/span_scanner_test.dart	View	1 chunk	+47 lines, -37 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 3 months ago (2015-09-02 18:45:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ad926d6c2840dd1248f07ed9c0b640f2620d2449 (presubmit successful).