Issue 131853003: Reenable analyze_api and add exceptions to white-list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131853003: Reenable analyze_api and add exceptions to white-list. (Closed)

Created:
6 years, 11 months ago by Johnni Winther

Modified:
6 years, 11 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, floitsch, blois

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reenable analyze_api and add exceptions to white-list. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=31690

Patch Set 1 #

Patch Set 2 : Add comments and messages. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -15 lines)			Patch
M	tests/compiler/dart2js/analyze_api_test.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/analyze_helper.dart	View	1	5 chunks	+36 lines, -12 lines	0 comments	Download
M	tests/compiler/dart2js/dart2js.status	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

Committed patchset #2 manually as r31690 (presubmit successful).

6 years, 11 months ago (2014-01-10 11:46:36 UTC) #3

vsm

On 2014/01/10 11:46:36, Johnni Winther wrote: > Committed patchset #2 manually as r31690 (presubmit successful). ...

6 years, 11 months ago (2014-01-10 16:38:16 UTC) #4

Johnni Winther

6 years, 11 months ago (2014-01-10 17:37:43 UTC) #5

Message was sent while issue was closed.

On 2014/01/10 16:38:16, vsm wrote:
> On 2014/01/10 11:46:36, Johnni Winther wrote:
> > Committed patchset #2 manually as r31690 (presubmit successful).
> 
> Thanks, Johnni.
> 
> I'll be checking in a real fix shortly.  I assume I only need to revert the
> analyze_api_test.dart changes here.

Yes.

Expand Messages | Collapse Messages