dart2js CPS: simple inlining of static invocations.

dart2js CPS: simple inlining of static invocations.

Inline static functions whose bodies are a single Dart expression that
just calls a foreign (native) function.  This eliminates a lot of
overhead from the code in the JavaScript runtime library.

R=asgerf@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/90039f64aee9db5ec30a781547659ec2e7fbceea

[asgerf, 2015-08-25 10:57:58]

LGTM

[Kevin Millikin (Google), 2015-08-25 11:38:17]

Committed patchset #1 (id:1) manually as
90039f64aee9db5ec30a781547659ec2e7fbceea (presubmit successful).

[karlklose, 2015-08-25 11:57:12]

karlklose@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-08-25 11:57:13]

DBC:

https://codereview.chromium.org/1318453003/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1318453003/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:1664: // The target might not
have an AST, for example if it deferred.
'if it *is* deferred.'

I think 'hasNode' is only false if the target is the synthetic loader function
for a deferred library (or an erroneous element).

https://codereview.chromium.org/1318453003/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:1688: if (node.target.name ==
'getInterceptor') return false;
You should compare the elements instead of the name.  Long term, we should
remove the 'magic' getInterceptor implementation, since we do not need its
element in the CPS backend.

https://codereview.chromium.org/1318453003/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:1698: var link =
body.statements.nodes;
'var' -> 'Link<Node>'.

https://codereview.chromium.org/1318453003/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:1699: if (link.isNotEmpty &&
link.tail.isEmpty) {
How about moving the test for interceptors out of this helper and make the node
a parameter? Then you could write:
  if (body is ast.Return || body is ast.ExpressionBlock) {
    return isNonExpansive(body.expression);
  } else if (body is ast.Block) {
    ...
      return shouldInline(link.head);
  }

[sra1, 2015-08-25 20:42:04]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-08-25 20:42:04]

https://codereview.chromium.org/1318453003/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1318453003/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:1687: // with the same name.
We should add a @NoInline() annotation on definition in js_library.

Please also honor the @NoInline() annotation on makeDispatchRecord() at
interceptors.dart line 95.