Extract ReceiverMask interface from TypeMask.

Extract ReceiverMask interface from TypeMask.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/82e96229693293f65ae3fb57d7555a8cb9f40e4f

[Johnni Winther, 2015-08-31 12:27:55]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2015-08-31 12:27:56]

Main changes in universe.dart and types.dart

[Johnni Winther, 2015-08-31 12:28:49]

Well, type_mask.dart instead of types.dart!

[Siggi Cherem (dart-lang), 2015-09-01 02:12:59]

lgtm

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart (right):

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart:224: if
(callSelectors == null) callSelectors = const <Selector, ReceiverMaskSet>{};
nit: wrap

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/universe.dart (right):

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:48: /// invoked on this type mask.
[selector] is used to ensure library
type => receiver?

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:63: abstract class ReceiverMaskSet {
let's keep the term for now, but I wonder if "mask" is just an implementation
term we might want to use only for TypeMask?

ReceiverMarkSet could become ReceiverSet, I'm not sure what to call ReceiverMask
though.

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:86: bool
addReceiverMask(ReceiverMask mask);
if this is the main API to add a possible receiver, I wonder whether we gain
from using the ReceiverMask abstraction in this external API, or if we should
simply specify which element may become a receiver directly here:

  bool addReceiver(ClassElement element, Selector selector);

Maybe something we can brainstorm more about on our next meeting? For now I
think it's ok to submit as is.

[Johnni Winther, 2015-09-01 07:39:28]

Committed patchset #2 (id:20001) manually as
82e96229693293f65ae3fb57d7555a8cb9f40e4f (presubmit successful).

[Johnni Winther, 2015-09-01 08:15:51]

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart (right):

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart:224: if
(callSelectors == null) callSelectors = const <Selector, ReceiverMaskSet>{};
On 2015/09/01 02:12:59, Siggi Cherem (dart-lang) wrote:
> nit: wrap

Done.

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/universe.dart (right):

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:48: /// invoked on this type mask.
[selector] is used to ensure library
On 2015/09/01 02:12:59, Siggi Cherem (dart-lang) wrote:
> type => receiver?

Done.

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:63: abstract class ReceiverMaskSet {
On 2015/09/01 02:12:59, Siggi Cherem (dart-lang) wrote:
> let's keep the term for now, but I wonder if "mask" is just an implementation
> term we might want to use only for TypeMask?
> 
> ReceiverMarkSet could become ReceiverSet, I'm not sure what to call
ReceiverMask
> though.

Acknowledged.

https://codereview.chromium.org/1318383002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:86: bool
addReceiverMask(ReceiverMask mask);
On 2015/09/01 02:12:59, Siggi Cherem (dart-lang) wrote:
> if this is the main API to add a possible receiver, I wonder whether we gain
> from using the ReceiverMask abstraction in this external API, or if we should
> simply specify which element may become a receiver directly here:
> 
>   bool addReceiver(ClassElement element, Selector selector);
> 
> Maybe something we can brainstorm more about on our next meeting? For now I
> think it's ok to submit as is.

Acknowledged.