Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 13181004: Add constructor test (Closed)

Created:
7 years, 9 months ago by hausner
Modified:
7 years, 9 months ago
Reviewers:
gbracha, Ivan Posva
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Add constructor test Constructor has side effects mutating the parameters and checking whether the mutated values are remembered in the constructor body. Committed: https://code.google.com/p/dart/source/detail?r=20638

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A tests/language/constructor_initializer_test.dart View 1 1 chunk +37 lines, -0 lines 0 comments Download
M tests/language/language.status View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hausner
7 years, 9 months ago (2013-03-28 16:55:44 UTC) #1
gbracha
lgtm
7 years, 9 months ago (2013-03-28 17:40:42 UTC) #2
Ivan Posva
https://codereview.chromium.org/13181004/diff/1/tests/language/constructor_initializer_test.dart File tests/language/constructor_initializer_test.dart (right): https://codereview.chromium.org/13181004/diff/1/tests/language/constructor_initializer_test.dart#newcode29 tests/language/constructor_initializer_test.dart:29: var o = new B(3, 5); Please make sure ...
7 years, 9 months ago (2013-03-28 17:46:27 UTC) #3
hausner
https://codereview.chromium.org/13181004/diff/1/tests/language/constructor_initializer_test.dart File tests/language/constructor_initializer_test.dart (right): https://codereview.chromium.org/13181004/diff/1/tests/language/constructor_initializer_test.dart#newcode29 tests/language/constructor_initializer_test.dart:29: var o = new B(3, 5); On 2013/03/28 17:46:27, ...
7 years, 9 months ago (2013-03-28 20:06:47 UTC) #4
hausner
7 years, 9 months ago (2013-03-28 20:07:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20638 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698