Issue 1318003006: Revert "Add version validation for LookupMap, also add unittest directly in LookupMap."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1318003006: Revert "Add version validation for LookupMap, also add unittest directly in LookupMap." (Closed)

Created:
5 years, 3 months ago by Siggi Cherem (dart-lang)

Modified:
5 years, 3 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Add version validation for LookupMap, also add unittest directly in LookupMap." This reverts commit fc582d7a3da8373a0b2d1e98e582afd2d00d6861 due to lots of redness TBR=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/9b8c06d22589081ded70dc3effd755ac3e8ed5b7

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -185 lines)			Patch
M	pkg/compiler/lib/src/common/backend_api.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/compiler.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/diagnostics/messages.dart	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart	View	5 chunks	+9 lines, -59 lines	0 comments	Download
M	pkg/lookup_map/lib/lookup_map.dart	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	pkg/lookup_map/pubspec.yaml	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	pkg/lookup_map/test/lookup_map_test.dart	View	1 chunk	+0 lines, -74 lines	0 comments	Download
D	pkg/lookup_map/test/version_check_test.dart	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	pkg/pkg.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/mock_libraries.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Siggi Cherem (dart-lang)

5 years, 3 months ago (2015-09-04 21:05:46 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9b8c06d22589081ded70dc3effd755ac3e8ed5b7 (presubmit successful).