Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1317903002: dart2js cps: Use dummy constant in dummy receiver optimization. (Closed)

Created:
5 years, 3 months ago by asgerf
Modified:
5 years, 3 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Use dummy constant in dummy receiver optimization. Also addresses some other post-commit comments from https://codereview.chromium.org/1312393002 BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/4d20c86fd03aafb2d55d3efd9cbc1436a9ebdf0b

Patch Set 1 #

Patch Set 2 : Revert+Unrevert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 5 chunks +16 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 3 months ago (2015-08-26 16:44:27 UTC) #2
sra1
lgtm
5 years, 3 months ago (2015-08-26 16:48:07 UTC) #3
asgerf
5 years, 3 months ago (2015-08-27 09:34:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d20c86fd03aafb2d55d3efd9cbc1436a9ebdf0b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698