Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1317753004: Eliminate LocalVarDescriptors in some corner cases (Closed)

Created:
5 years, 3 months ago by hausner
Modified:
5 years, 3 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Eliminate LocalVarDescriptors in some corner cases Fix initializing functions so they can be recompiled if var descriptors are needed for a stack trace. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/9a79cbd78e5beddaddc1de68dfdd440983af592c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -21 lines) Patch
M runtime/vm/compiler.cc View 3 chunks +1 line, -16 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 3 months ago (2015-09-03 20:35:54 UTC) #2
srdjan
lgtm
5 years, 3 months ago (2015-09-03 20:39:01 UTC) #3
hausner
5 years, 3 months ago (2015-09-03 20:55:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a79cbd78e5beddaddc1de68dfdd440983af592c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698