Issue 1317683009: IO resource tracking. Add test that we correctly remove closed sockets

Issue 1317683009: IO resource tracking. Add test that we correctly remove closed sockets (Closed)

Created:
5 years, 3 months ago by ricow1

Modified:
5 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

IO resource tracking. Add test that we correctly remove closed sockets The other tests simply check that we actually get the open sockets, this will make sure we don't get sockets already closed R=sgjesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5a0a8aede9868ac46ce1367274d0624d85ea05b0

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : long line #

Total comments: 6

Patch Set 4 : address comments #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -0 lines)			Patch
	A	runtime/observatory/tests/service/tcp_socket_closing_service_test.dart	View	1 2 3	1 chunk	+74 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/1317683009/diff/40001/runtime/observatory/tests/service/tcp_socket_closing_service_test.dart File runtime/observatory/tests/service/tcp_socket_closing_service_test.dart (right): https://codereview.chromium.org/1317683009/diff/40001/runtime/observatory/tests/service/tcp_socket_closing_service_test.dart#newcode19 runtime/observatory/tests/service/tcp_socket_closing_service_test.dart:19: s.transform(UTF8.decoder).listen(print); listen(print) -> drain(); https://codereview.chromium.org/1317683009/diff/40001/runtime/observatory/tests/service/tcp_socket_closing_service_test.dart#newcode35 runtime/observatory/tests/service/tcp_socket_closing_service_test.dart:35: serverSocket.close(); await ...

5 years, 3 months ago (2015-09-02 14:34:17 UTC) #4

ricow1

https://codereview.chromium.org/1317683009/diff/40001/runtime/observatory/tests/service/tcp_socket_closing_service_test.dart File runtime/observatory/tests/service/tcp_socket_closing_service_test.dart (right): https://codereview.chromium.org/1317683009/diff/40001/runtime/observatory/tests/service/tcp_socket_closing_service_test.dart#newcode19 runtime/observatory/tests/service/tcp_socket_closing_service_test.dart:19: s.transform(UTF8.decoder).listen(print); On 2015/09/02 14:34:17, Søren Gjesse wrote: > listen(print) ...

5 years, 3 months ago (2015-09-03 17:34:59 UTC) #5

ricow1

5 years, 3 months ago (2015-09-04 03:55:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
5a0a8aede9868ac46ce1367274d0624d85ea05b0 (presubmit successful).

Expand Messages | Collapse Messages