Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1317563008: observatory: change help text to match break-on-exception option name (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly
Modified:
5 years, 3 months ago
Reviewers:
Cutch, rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

observatory: change help text to match break-on-exception option name R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e30f7638e2c25209d83b91ea834d8ef6650e7f34

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
https://codereview.chromium.org/1317563008/diff/1/runtime/observatory/lib/src/elements/debugger.dart File runtime/observatory/lib/src/elements/debugger.dart (right): https://codereview.chromium.org/1317563008/diff/1/runtime/observatory/lib/src/elements/debugger.dart#newcode523 runtime/observatory/lib/src/elements/debugger.dart:523: 'break-on-exception': [_boeValues, here's where the parameter is declared. you ...
5 years, 3 months ago (2015-09-02 23:22:41 UTC) #2
rmacnak
lgtm
5 years, 3 months ago (2015-09-02 23:38:04 UTC) #4
Jennifer Messerly
5 years, 3 months ago (2015-09-03 00:06:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e30f7638e2c25209d83b91ea834d8ef6650e7f34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698