Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1317213004: Use contributed ResultDescriptor(s) while computing DART_ERRORS. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use contributed ResultDescriptor(s) while computing DART_ERRORS. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/12614041e52daa2fe26bfd00b5237f5d6f9fee5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -47 lines) Patch
M pkg/analyzer/lib/plugin/task.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 7 chunks +75 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 4 chunks +28 lines, -43 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-09 21:53:03 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-09 22:09:56 UTC) #2
scheglov
5 years, 3 months ago (2015-09-09 22:12:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
12614041e52daa2fe26bfd00b5237f5d6f9fee5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698