Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 1317213003: Improve async code in VM by not unnecessarily capturing parameters of async and (Closed)

Created:
5 years, 3 months ago by regis
Modified:
5 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve async code in VM by not unnecessarily capturing parameters of async and sync closures, thereby avoiding copy of parameters on entry. Remove variable aliases in local scopes now that another mechanism detects use-before-define cases. Keep aliases only for captured variables of outer functions thereby speeding up scope lookups for all Dart code (not just async). The next step will be to try to reduce the number of captured variables in async code. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/e6225bee44fab8c5edfb7a167eecc09db23dd8c8

Patch Set 1 #

Patch Set 2 : Avoid duplicate aliases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -283 lines) Patch
M runtime/vm/flow_graph_builder.h View 3 chunks +0 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 4 chunks +12 lines, -169 lines 0 comments Download
M runtime/vm/parser.cc View 13 chunks +24 lines, -53 lines 0 comments Download
M runtime/vm/scopes.h View 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/vm/scopes.cc View 1 5 chunks +30 lines, -42 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
5 years, 3 months ago (2015-08-27 22:37:42 UTC) #2
hausner
LGTM. This is the nicest cleanup change I've seen in a long time!
5 years, 3 months ago (2015-08-27 23:21:20 UTC) #3
regis
Thanks! I have made a little improvement before submitting.
5 years, 3 months ago (2015-08-27 23:48:47 UTC) #4
regis
5 years, 3 months ago (2015-08-27 23:49:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e6225bee44fab8c5edfb7a167eecc09db23dd8c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698