Issue 13171004: - The callback_error_ handle was never being setup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13171004: - The callback_error_ handle was never being setup. (Closed)

Created:
7 years, 8 months ago by siva

Modified:
7 years, 8 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- The callback_error_ handle was never being setup. - Remove some unnecessary DARTSCOPE calls when true/false/null Dart_Handles are created. Committed: https://code.google.com/p/dart/source/detail?r=20701

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -29 lines)			Patch
M	runtime/vm/dart.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_state.h	View	1	5 chunks	+15 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with the offline comment about the name of callback_error. -Ivan

7 years, 8 months ago (2013-03-29 23:39:14 UTC) #2

siva

7 years, 8 months ago (2013-03-30 00:07:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20701 (presubmit successful).

Expand Messages | Collapse Messages