React gracefully to a fully-.gitignored package.

React gracefully to a fully-.gitignored package.

If the root directory of a package is .gitignored, it will no longer be
considered to be a "git package", since that just means that it'll be
seen to contain no files at all.

Closes #1321

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/a6a8a094894e0851b7dd98cfa8bd5d282b66c7ae

[Bob Nystrom, 2015-08-26 23:19:02]

https://codereview.chromium.org/1317043002/diff/1/lib/src/package.dart
File lib/src/package.dart (right):

https://codereview.chromium.org/1317043002/diff/1/lib/src/package.dart#newcod...
lib/src/package.dart:123: _inGitRepoCache = result.exitCode == 1;
Instead of making git.command public, how about moving this blob of code into
git.dart as a "isDirectoryIgnored" function? I like the idea of all of the
command line argument shenanigans for git being localized to one file in pub.

[nweiz, 2015-08-27 19:04:33]

https://codereview.chromium.org/1317043002/diff/1/lib/src/package.dart
File lib/src/package.dart (right):

https://codereview.chromium.org/1317043002/diff/1/lib/src/package.dart#newcod...
lib/src/package.dart:123: _inGitRepoCache = result.exitCode == 1;
On 2015/08/26 23:19:02, Bob Nystrom wrote:
> Instead of making git.command public, how about moving this blob of code into
> git.dart as a "isDirectoryIgnored" function? I like the idea of all of the
> command line argument shenanigans for git being localized to one file in pub.

I'll do this if you want, but I think a lot of the command-line shenanigans are
already pretty exposed. The wrapper functions in the git library are pretty low
level; the only thing they really do, other than the git command, is throw a
nice exception if git fails. So adding such a high-level function would be kind
of at odds with the existing API.

[Bob Nystrom, 2015-08-27 20:40:36]

I'm OK either way. LGTM!

[nweiz, 2015-08-27 23:34:33]

Committed patchset #1 (id:1) manually as
a6a8a094894e0851b7dd98cfa8bd5d282b66c7ae (presubmit successful).