Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1317023002: show all available import completion suggestions - fixes #23955 (Closed)

Created:
5 years, 3 months ago by danrubel
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

show all available import completion suggestions - fixes #23955 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/c0fe214c471ebad29b921b9070dc9293fdcd256c

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -55 lines) Patch
M pkg/analysis_server/lib/src/services/completion/import_uri_contributor.dart View 1 6 chunks +14 lines, -24 lines 0 comments Download
M pkg/analysis_server/test/services/completion/import_uri_contributor_test.dart View 11 chunks +30 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 3 months ago (2015-08-26 20:51:30 UTC) #2
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-08-26 20:54:19 UTC) #3
danrubel
5 years, 3 months ago (2015-08-26 21:37:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c0fe214c471ebad29b921b9070dc9293fdcd256c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698