Clean up default parameter computation in parser

Clean up default parameter computation in parser

BUG=
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/5985718945465aa3dcb57b3e90a0157e2f4d8e92

[srdjan, 2015-08-25 20:28:15]

srdjan@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-08-25 21:21:56]

LGTM with suggestion.

https://codereview.chromium.org/1316763002/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1316763002/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:7216: void Parser::SetupDefaultsForOptionalParams(const
ParamList& params) {
If you guard this like so:

if (current_function() != innermost_function() {
  return;
}

Then you don't have to save and restore the default values when ParseFunc() is
called recursively.

https://codereview.chromium.org/1316763002/diff/20001/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/1316763002/diff/20001/runtime/vm/parser.h#new...
runtime/vm/parser.h:90: if (list == NULL) return;
This should be inside the #if block.

[srdjan, 2015-08-25 21:49:40]

Thanks!

https://codereview.chromium.org/1316763002/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1316763002/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:7216: void Parser::SetupDefaultsForOptionalParams(const
ParamList& params) {
On 2015/08/25 21:21:56, hausner wrote:
> If you guard this like so:
> 
> if (current_function() != innermost_function() {
>   return;
> }
> 
> Then you don't have to save and restore the default values when ParseFunc() is
> called recursively.

Done.

https://codereview.chromium.org/1316763002/diff/20001/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/1316763002/diff/20001/runtime/vm/parser.h#new...
runtime/vm/parser.h:90: if (list == NULL) return;
On 2015/08/25 21:21:56, hausner wrote:
> This should be inside the #if block.

Done.

[srdjan, 2015-08-25 21:54:56]

Committed patchset #3 (id:40001) manually as
5985718945465aa3dcb57b3e90a0157e2f4d8e92 (presubmit successful).