Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1316753003: Ignore non-existent analysis roots. (Closed)

Created:
5 years, 3 months ago by Paul Berry
Modified:
5 years, 3 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 3 months ago (2015-09-07 20:03:03 UTC) #2
danrubel
lgtm
5 years, 3 months ago (2015-09-08 12:24:12 UTC) #3
Paul Berry
5 years, 3 months ago (2015-09-08 12:36:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b39928e01dff089368c9d8bc48ce51b6f890225e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698