Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1316673006: dart2js cps: Use TypeMaskSystem when inserting refinement nodes. (Closed)

Created:
5 years, 3 months ago by asgerf
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Use TypeMaskSystem when inserting refinement nodes. This also fixes a precision bug where checks like 'x is String' would refine to [subtype=String] instead of [exact=JSString]. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/249a2affaa263c0ce8f275052ab4565eda5d12c4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused ClassElement variable && rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -278 lines) Patch
M pkg/compiler/lib/src/cps_ir/insert_refinements.dart View 1 6 chunks +11 lines, -22 lines 0 comments Download
A pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 chunk +298 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 3 chunks +9 lines, -253 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
https://codereview.chromium.org/1316673006/diff/1/pkg/compiler/lib/src/cps_ir/type_mask_system.dart File pkg/compiler/lib/src/cps_ir/type_mask_system.dart (right): https://codereview.chromium.org/1316673006/diff/1/pkg/compiler/lib/src/cps_ir/type_mask_system.dart#newcode24 pkg/compiler/lib/src/cps_ir/type_mask_system.dart:24: There are two new methods at the end, the ...
5 years, 3 months ago (2015-09-04 13:53:01 UTC) #2
Kevin Millikin (Google)
lgtm
5 years, 3 months ago (2015-09-07 09:02:13 UTC) #3
asgerf
5 years, 3 months ago (2015-09-08 14:17:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
249a2affaa263c0ce8f275052ab4565eda5d12c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698