Remove more GrowableObjectArray usage in parser

Remove more GrowableObjectArray usage in parser


Allocate appropriate data structures in old space from beginning

BUG=
R=koda@google.com

Committed: https://github.com/dart-lang/sdk/commit/f857c1ba8e4d97e9a38e5a8c2db8e5b9435fbe54

[srdjan, 2015-08-27 20:17:20]

srdjan@google.com changed reviewers:
+ koda@google.com

[koda, 2015-08-27 20:27:53]

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/class_finalizer....
runtime/vm/class_finalizer.cc:2219: 
I believe style guide advises to avoid blank lines after "}".

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/object.h#newcode14
runtime/vm/object.h:14: #include "vm/globals.h"
Include or forward-declare GrowableArray.

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:697: functions_(4),
functions_(zone, 4)
Ditto for fields, and again below.

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:6123: (top_level.fields().length() > 0) ||
(top_level.functions().length() > 0)) {
Consider one comparison per line, aligned.

[srdjan, 2015-08-27 20:39:49]

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/class_finalizer....
runtime/vm/class_finalizer.cc:2219: 
On 2015/08/27 20:27:52, koda wrote:
> I believe style guide advises to avoid blank lines after "}".

Removed. Did not know about that rule.

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/object.h#newcode14
runtime/vm/object.h:14: #include "vm/globals.h"
On 2015/08/27 20:27:53, koda wrote:
> Include or forward-declare GrowableArray.

included

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:697: functions_(4),
On 2015/08/27 20:27:53, koda wrote:
> functions_(zone, 4)
> Ditto for fields, and again below.

Done.

https://codereview.chromium.org/1316373002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:6123: (top_level.fields().length() > 0) ||
(top_level.functions().length() > 0)) {
On 2015/08/27 20:27:53, koda wrote:
> Consider one comparison per line, aligned.

Done.

[koda, 2015-08-27 20:40:49]

lgtm

[srdjan, 2015-08-27 20:46:49]

Committed patchset #2 (id:20001) manually as
f857c1ba8e4d97e9a38e5a8c2db8e5b9435fbe54 (presubmit successful).