Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13163002: Roll IDLs. (Closed)

Created:
7 years, 9 months ago by Anton Muhin
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -260 lines) Patch
A Modules/geolocation/Coordinates.idl View 1 chunk +38 lines, -0 lines 0 comments Download
M Modules/mediasource/MediaSource.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Modules/mediastream/RTCPeerConnection.idl View 2 chunks +2 lines, -6 lines 0 comments Download
M Modules/mediastream/RTCStatsReport.idl View 1 chunk +1 line, -0 lines 0 comments Download
A Modules/quota/WorkerNavigatorStorageQuota.idl View 1 chunk +26 lines, -0 lines 0 comments Download
M Modules/speech/SpeechRecognitionEvent.idl View 1 chunk +2 lines, -5 lines 0 comments Download
M Modules/webaudio/AudioBufferSourceNode.idl View 1 chunk +1 line, -1 line 0 comments Download
D Modules/webaudio/AudioGain.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M Modules/webaudio/GainNode.idl View 1 chunk +1 line, -1 line 0 comments Download
M README View 1 chunk +1 line, -1 line 0 comments Download
M WebCore.gyp/scripts/action_makenames.py View 1 chunk +2 lines, -0 lines 0 comments Download
M bindings/dart/gyp/scripts/massage_factories.py View 2 chunks +6 lines, -6 lines 0 comments Download
M bindings/scripts/test/TestObj.idl View 2 chunks +9 lines, -0 lines 0 comments Download
M dom/Document.idl View 6 chunks +21 lines, -15 lines 2 comments Download
M dom/Element.idl View 8 chunks +75 lines, -74 lines 0 comments Download
M dom/Node.idl View 3 chunks +22 lines, -21 lines 0 comments Download
A dom/SecurityPolicyViolationEvent.idl View 1 chunk +37 lines, -0 lines 0 comments Download
M dom/ShadowRoot.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M dom/Text.idl View 2 chunks +8 lines, -2 lines 2 comments Download
M html/HTMLElement.idl View 1 chunk +1 line, -1 line 0 comments Download
A html/canvas/WebGLCompressedTexturePVRTC.idl View 1 chunk +37 lines, -0 lines 0 comments Download
M html/shadow/HTMLContentElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M html/track/TextTrack.idl View 1 chunk +7 lines, -0 lines 0 comments Download
A html/track/TextTrackRegionList.idl View 1 chunk +36 lines, -0 lines 1 comment Download
M inspector/InjectedScriptHost.idl View 1 chunk +10 lines, -1 line 0 comments Download
M inspector/Inspector.json View 24 chunks +52 lines, -50 lines 0 comments Download
M inspector/compile-front-end.py View 2 chunks +2 lines, -0 lines 0 comments Download
A inspector/front-end/ace/LICENSE.txt View 1 chunk +24 lines, -0 lines 0 comments Download
D page/Coordinates.idl View 1 chunk +0 lines, -37 lines 0 comments Download
M page/DOMWindow.idl View 2 chunks +3 lines, -2 lines 0 comments Download
M testing/Internals.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anton Muhin
7 years, 9 months ago (2013-03-28 14:09:24 UTC) #1
Anton Muhin
https://codereview.chromium.org/13163002/diff/1/dom/Document.idl File dom/Document.idl (right): https://codereview.chromium.org/13163002/diff/1/dom/Document.idl#newcode32 dom/Document.idl:32: [ReturnNewObject, V8DeliverCustomElementCallbacks, V8PerWorldBindings] I'll take a look at those ...
7 years, 9 months ago (2013-03-28 14:13:49 UTC) #2
Anton Muhin
Committed patchset #1 manually as r20616 (presubmit successful).
7 years, 9 months ago (2013-03-28 14:14:50 UTC) #3
Anton Muhin
https://codereview.chromium.org/13163002/diff/1/dom/Document.idl File dom/Document.idl (right): https://codereview.chromium.org/13163002/diff/1/dom/Document.idl#newcode32 dom/Document.idl:32: [ReturnNewObject, V8DeliverCustomElementCallbacks, V8PerWorldBindings] On 2013/03/28 14:13:49, Anton Muhin wrote: ...
7 years, 9 months ago (2013-03-28 17:16:53 UTC) #4
Mads Ager (google)
7 years, 8 months ago (2013-04-02 08:17:04 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698