Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 131623006: Skipping dartanalyzer for Angular tests (Closed)

Created:
6 years, 11 months ago by blois
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org, scheglov
Visibility:
Public.

Description

Skipping dartanalyzer for Angular tests Latest Angular bits appear to be crashing the analyzer. CL which updated Angular is https://code.google.com/p/dart/source/detail?r=32035. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32041

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/pkg.status View 1 3 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
blois
6 years, 11 months ago (2014-01-27 22:59:37 UTC) #1
blois
https://codereview.chromium.org/131623006/diff/10001/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/131623006/diff/10001/pkg/pkg.status#newcode200 pkg/pkg.status:200: third_party/angular_tests/browser_test/core_dom/cookies: Fail # Issue 16337 And just applying this ...
6 years, 11 months ago (2014-01-27 23:02:52 UTC) #2
Siggi Cherem (dart-lang)
lgtm
6 years, 11 months ago (2014-01-27 23:17:58 UTC) #3
blois
6 years, 11 months ago (2014-01-27 23:26:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r32041 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698