Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 1315863004: Add a print statement for recompilations. (Closed)

Created:
5 years, 3 months ago by siva
Modified:
5 years, 3 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a print statement for recompilations. BUG= Committed: https://github.com/dart-lang/sdk/commit/141d0913e934b2e1019271e2240926347527c84b

Patch Set 1 #

Total comments: 4

Patch Set 2 : code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M runtime/vm/code_generator.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 3 months ago (2015-08-31 17:10:15 UTC) #2
srdjan
LGTMwC https://codereview.chromium.org/1315863004/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/1315863004/diff/1/runtime/vm/code_generator.cc#newcode61 runtime/vm/code_generator.cc:61: DECLARE_FLAG(bool, trace_compiler); Alphabetical sort, please. https://codereview.chromium.org/1315863004/diff/1/runtime/vm/code_generator.cc#newcode1479 runtime/vm/code_generator.cc:1479: ISL_Print("ReCompiling ...
5 years, 3 months ago (2015-08-31 17:13:56 UTC) #3
siva
https://codereview.chromium.org/1315863004/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/1315863004/diff/1/runtime/vm/code_generator.cc#newcode61 runtime/vm/code_generator.cc:61: DECLARE_FLAG(bool, trace_compiler); On 2015/08/31 17:13:56, srdjan wrote: > Alphabetical ...
5 years, 3 months ago (2015-08-31 20:12:23 UTC) #4
siva
5 years, 3 months ago (2015-08-31 20:19:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
141d0913e934b2e1019271e2240926347527c84b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698