Issue 131583004: Add documentation to the FileSystemException class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131583004: Add documentation to the FileSystemException class (Closed)

Created:
6 years, 11 months ago by Søren Gjesse

Modified:
6 years, 11 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add documentation to the FileSystemException class Also update toString slightly. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31692

Patch Set 2 : Addressed review comments #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -3 lines)			Patch
	M	sdk/lib/io/file.dart	View	1	2 chunks	+29 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/131583004/diff/1/sdk/lib/io/file.dart File sdk/lib/io/file.dart (right): https://codereview.chromium.org/131583004/diff/1/sdk/lib/io/file.dart#newcode589 sdk/lib/io/file.dart:589: * [message], optional file system path [path] and ...

6 years, 11 months ago (2014-01-10 08:48:43 UTC) #2

Søren Gjesse

https://codereview.chromium.org/131583004/diff/1/sdk/lib/io/file.dart File sdk/lib/io/file.dart (right): https://codereview.chromium.org/131583004/diff/1/sdk/lib/io/file.dart#newcode589 sdk/lib/io/file.dart:589: * [message], optional file system path [path] and OS ...

6 years, 11 months ago (2014-01-10 11:44:20 UTC) #3

Søren Gjesse

6 years, 11 months ago (2014-01-10 12:30:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r31692 (presubmit successful).

Expand Messages | Collapse Messages

Issue 131583004: Add documentation to the FileSystemException class (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages