Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315483006: Split scannerlib.dart into several libraries. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update try tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -159 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/diagnostics/source_span.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirror_renamer/mirror_renamer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 2 chunks +16 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 2 chunks +17 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/array_based_scanner.dart View 1 chunk +26 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/class_element_parser.dart View 1 chunk +43 lines, -1 line 0 comments Download
A pkg/compiler/lib/src/scanner/diet_parser_task.dart View 1 chunk +41 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/scanner/keyword.dart View 1 chunk +10 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/listener.dart View 2 chunks +66 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/scanner/parser.dart View 1 chunk +56 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/parser_task.dart View 1 chunk +20 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/partial_parser.dart View 1 chunk +16 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/scanner.dart View 1 chunk +16 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/scanner_task.dart View 2 chunks +18 lines, -20 lines 0 comments Download
D pkg/compiler/lib/src/scanner/scannerlib.dart View 1 chunk +0 lines, -64 lines 0 comments Download
M pkg/compiler/lib/src/scanner/string_scanner.dart View 1 chunk +12 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/token.dart View 1 chunk +16 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/token_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/utf8_bytes_scanner.dart View 1 chunk +15 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/string_validator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/tree.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/dart2js_incremental/lib/diff.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 1 chunk +14 lines, -6 lines 0 comments Download
M site/try/poi/poi.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M site/try/src/editor.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M site/try/src/interaction_manager.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_printer_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/metadata_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/scanner_offset_length_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/scanner_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/try/poi/apply_updates_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/try/poi/forget_element_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in the src/scanner/*.dart files
5 years, 3 months ago (2015-09-01 13:02:08 UTC) #2
karlklose
LGTM.
5 years, 3 months ago (2015-09-01 13:10:56 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as f5a7be0c173bd9015153919e5fcf998031d16ebf (presubmit successful).
5 years, 3 months ago (2015-09-01 13:39:41 UTC) #4
Siggi Cherem (dart-lang)
5 years, 3 months ago (2015-09-01 16:48:42 UTC) #5
Message was sent while issue was closed. 
lgtm, yay!

Powered by Google App Engine
This is Rietveld 408576698