Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 131543012: Don't have polymer thinking unmodifiable_collection is in pkg. (Closed)

Created:
6 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Visibility:
Public.

Description

Don't have polymer thinking unmodifiable_collection is in pkg. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32546

Patch Set 1 #

Patch Set 2 : Update version number. #

Total comments: 2

Patch Set 3 : Don't update version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/polymer/lib/src/build/runner.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
6 years, 10 months ago (2014-02-10 15:12:20 UTC) #1
Lasse Reichstein Nielsen
I'm not sure they even use unmodifiable_collection anywhere.
6 years, 10 months ago (2014-02-10 15:15:38 UTC) #2
Siggi Cherem (dart-lang)
Hi Lasse, thanks for the fix! LGTM, but we could also wait for Pete's change ...
6 years, 10 months ago (2014-02-10 18:40:55 UTC) #3
Lasse Reichstein Nielsen
Ok, I will defer to Pete's change then. https://codereview.chromium.org/131543012/diff/40001/pkg/polymer/pubspec.yaml File pkg/polymer/pubspec.yaml (right): https://codereview.chromium.org/131543012/diff/40001/pkg/polymer/pubspec.yaml#newcode2 pkg/polymer/pubspec.yaml:2: version: ...
6 years, 10 months ago (2014-02-11 06:37:39 UTC) #4
Lasse Reichstein Nielsen
6 years, 10 months ago (2014-02-11 09:15:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r32546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698