Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1315423002: pkg/source_span: Eliminate dart2js warning about overriding `==`, but not `hashCode`. (Closed)

Created:
5 years, 3 months ago by kevmoo
Modified:
5 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/source_span.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Eliminate dart2js warning about overriding `==`, but not `hashCode`. Closes dart-lang/source_span#5 R=nweiz@google.com Committed: https://github.com/dart-lang/source_span/commit/3cf8669673b639b164e5f46fd358983051d15b0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/file.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kevmoo
5 years, 3 months ago (2015-08-27 21:03:32 UTC) #2
nweiz
lgtm
5 years, 3 months ago (2015-08-28 00:35:32 UTC) #3
kevmoo
5 years, 3 months ago (2015-08-28 01:14:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3cf8669673b639b164e5f46fd358983051d15b0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698