Issue 1315083002: dart2js: Use the NoInline annotation on getInterceptor in the JS runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1315083002: dart2js: Use the NoInline annotation on getInterceptor in the JS runtime. (Closed)

Created:
5 years, 3 months ago by Kevin Millikin (Google)

Modified:
5 years, 3 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: Use the NoInline annotation on getInterceptor in the JS runtime. This also requires fixing NoInline to work for the JS runtime. Previously it was ignored. R=karlklose@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e99fb4fc26bea757fb5b3f310e4caf6c2d1f9f99

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -9 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	2 chunks	+4 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/interceptors.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Google)

5 years, 3 months ago (2015-08-26 08:56:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e99fb4fc26bea757fb5b3f310e4caf6c2d1f9f99 (presubmit successful).