Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1314993002: Use correct scope to lookup saved async context variable. (Closed)

Created:
5 years, 3 months ago by regis
Modified:
5 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use correct scope to lookup saved async context variable. Stop inserting aliases in all intermediary scopes for explicitly captured variables. Use proper lookup function in async code to access async completer variable. Add asserts verifying async variables existence. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/a799659bcfd1d36593539390404b20ca09122223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -31 lines) Patch
M runtime/vm/parser.cc View 10 chunks +64 lines, -25 lines 0 comments Download
M runtime/vm/scopes.cc View 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
regis
This is a first round of cleanups before trying to reduce the number of captured ...
5 years, 3 months ago (2015-08-25 22:09:12 UTC) #2
hausner
lgtm
5 years, 3 months ago (2015-08-25 22:44:47 UTC) #3
regis
5 years, 3 months ago (2015-08-25 22:46:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a799659bcfd1d36593539390404b20ca09122223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698