Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314973003: Add support for analyzing individual URIs. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, lukechurch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -33 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 4 chunks +37 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/source_span.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 9 chunks +63 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 3 chunks +5 lines, -1 line 0 comments Download
A tests/compiler/dart2js/analyze_dart2js_helpers_test.dart View 1 1 chunk +235 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/incremental/compile_all.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_source_information_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 4 chunks +12 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes: - Compiler.analyzeUri added in compiler.dart - EnqueueStrategy added in enqueue.dart
5 years, 3 months ago (2015-08-28 11:09:04 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1314973003/diff/1/tests/compiler/dart2js/analyze_dart2js_helpers_test.dart File tests/compiler/dart2js/analyze_dart2js_helpers_test.dart (right): https://codereview.chromium.org/1314973003/diff/1/tests/compiler/dart2js/analyze_dart2js_helpers_test.dart#newcode101 tests/compiler/dart2js/analyze_dart2js_helpers_test.dart:101: //print('analyze:$resolvedAst'); Remove or put into verbose block.
5 years, 3 months ago (2015-08-28 11:38:26 UTC) #3
Johnni Winther
https://codereview.chromium.org/1314973003/diff/1/tests/compiler/dart2js/analyze_dart2js_helpers_test.dart File tests/compiler/dart2js/analyze_dart2js_helpers_test.dart (right): https://codereview.chromium.org/1314973003/diff/1/tests/compiler/dart2js/analyze_dart2js_helpers_test.dart#newcode101 tests/compiler/dart2js/analyze_dart2js_helpers_test.dart:101: //print('analyze:$resolvedAst'); On 2015/08/28 11:38:26, karlklose wrote: > Remove or ...
5 years, 3 months ago (2015-08-28 11:45:51 UTC) #4
Johnni Winther
5 years, 3 months ago (2015-08-28 11:50:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d8e5194c3b4d1cc3c742ce67fc06dec174f76a43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698