Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1314893003: sdk/dartanalyzer now detects an available build (Closed)

Created:
5 years, 4 months ago by stanm
Modified:
5 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Mads Ager (google), zerny-google
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

sdk/dartanalyzer now detects an available build Similar to CL 1276333002; this allows the dartanalyzer script to pick an available build, rather than failing if ReleaseIA32 is not available. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/fe402c50ea50aae4230b40aaab4e08ed3a71b2fc

Patch Set 1 #

Patch Set 2 : Make path better #

Patch Set 3 : Stupid mistake #

Patch Set 4 : rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M sdk/bin/dartanalyzer View 1 2 1 chunk +31 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
stanm
Like the 'dart' script in sdk/bin, the 'dartanalyzer' script now detects a build if there ...
5 years, 4 months ago (2015-08-25 15:43:09 UTC) #2
floitsch
LGTM.
5 years, 4 months ago (2015-08-25 18:14:10 UTC) #3
stanm
5 years, 4 months ago (2015-08-25 18:48:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
fe402c50ea50aae4230b40aaab4e08ed3a71b2fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698