Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1314763005: Change how instance/list/map references are displayed when expanded. (Closed)

Created:
5 years, 4 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change how instance/list/map references are displayed when expanded. The goal is to not indent as deeply as we were doing before. Stop using tables. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1587f88c2da2fc722ddc36f77830f6d360410108

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Patch Set 3 : move branches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -73 lines) Patch
M runtime/observatory/lib/src/elements/instance_ref.html View 1 7 chunks +40 lines, -73 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
turnidge
5 years, 4 months ago (2015-08-25 21:37:25 UTC) #2
rmacnak
https://codereview.chromium.org/1314763005/diff/1/runtime/observatory/lib/src/elements/instance_ref.html File runtime/observatory/lib/src/elements/instance_ref.html (right): https://codereview.chromium.org/1314763005/diff/1/runtime/observatory/lib/src/elements/instance_ref.html#newcode62 runtime/observatory/lib/src/elements/instance_ref.html:62: <a on-click="{{ goto }}" _href="{{ url }}"><em>List</em> ({{ ref.length ...
5 years, 4 months ago (2015-08-25 21:53:47 UTC) #3
turnidge
Please take another look. https://codereview.chromium.org/1314763005/diff/1/runtime/observatory/lib/src/elements/instance_ref.html File runtime/observatory/lib/src/elements/instance_ref.html (right): https://codereview.chromium.org/1314763005/diff/1/runtime/observatory/lib/src/elements/instance_ref.html#newcode62 runtime/observatory/lib/src/elements/instance_ref.html:62: <a on-click="{{ goto }}" _href="{{ ...
5 years, 3 months ago (2015-08-26 17:12:45 UTC) #4
rmacnak
lgtm
5 years, 3 months ago (2015-08-26 17:13:07 UTC) #5
turnidge
5 years, 3 months ago (2015-08-26 18:20:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1587f88c2da2fc722ddc36f77830f6d360410108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698