Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 13144018: Add text location in debugger event (Closed)

Created:
7 years, 8 months ago by hausner
Modified:
7 years, 8 months ago
Reviewers:
devoncarew, Tom Ball
CC:
reviews_dartlang.org, keertip
Visibility:
Public.

Description

Add text location in debugger event - Adding token number in text location data. Line number will be removed when the editor knows how to convert a token number to its line number. - "location" field in stack frames is now optional. If it is not present, there is no corresponding textual location for the code location. - Add location info of "paused" and "interrupted" events. Stack trace will go away in these events. Committed: https://code.google.com/p/dart/source/detail?r=20816

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -5 lines) Patch
M runtime/bin/dbg_message.cc View 1 2 3 5 chunks +46 lines, -5 lines 0 comments Download
M runtime/include/dart_debugger_api.h View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hausner
7 years, 8 months ago (2013-04-01 17:46:27 UTC) #1
Tom Ball
lgtm https://codereview.chromium.org/13144018/diff/2002/runtime/bin/dbg_message.cc File runtime/bin/dbg_message.cc (right): https://codereview.chromium.org/13144018/diff/2002/runtime/bin/dbg_message.cc#newcode948 runtime/bin/dbg_message.cc:948: // trace from the paused event in the ...
7 years, 8 months ago (2013-04-02 16:24:54 UTC) #2
hausner
https://codereview.chromium.org/13144018/diff/2002/runtime/bin/dbg_message.cc File runtime/bin/dbg_message.cc (right): https://codereview.chromium.org/13144018/diff/2002/runtime/bin/dbg_message.cc#newcode948 runtime/bin/dbg_message.cc:948: // trace from the paused event in the wire ...
7 years, 8 months ago (2013-04-02 17:15:23 UTC) #3
devoncarew
lgtm This looks fine from the editor side. I'll prepare a CL which removes use ...
7 years, 8 months ago (2013-04-02 20:20:53 UTC) #4
hausner
7 years, 8 months ago (2013-04-02 20:41:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r20816 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698