Implement spawnDomUri.

Implement spawnDomUri.

Also fix some bugs in the test.

R=podivilov@chromium.org,vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=20776

[vsm, 2013-04-01 14:07:18]

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
File tests/html/dom_isolates_test.dart (right):

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
tests/html/dom_isolates_test.dart:39:
spawnDomFunction(childDomIsolate).then(expectAsync1(
I think expectAsync1 needs to be at the top-level to be effective.  E.g.,

final callback = expectAsync1(...);
spawnDomFunction(childDomIsolate).then(callback);

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
tests/html/dom_isolates_test.dart:47:
spawnDomFunction(trampolineIsolate).then(expectAsync1(
ditto

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
tests/html/dom_isolates_test.dart:60:
spawnDomUri('dom_isolates_test.dart.child_isolate.dart').then(expectAsync1(
ditto

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
File tests/html/dom_isolates_test.dart.child_isolate.dart (right):

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
tests/html/dom_isolates_test.dart.child_isolate.dart:1: import 'dart:html';
Standard copyright message?

https://chromiumcodereview.appspot.com/13144014/diff/1/tools/dom/src/native_D...
File tools/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/13144014/diff/1/tools/dom/src/native_D...
tools/dom/src/native_DOMImplementation.dart:62: static void
spawnDomFunction(Function f, int replyTo) native "Utils_spawnDomFunction";
Does f no longer need to be a top-level function?

[Anton Muhin, 2013-04-01 14:18:17]

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
File tests/html/dom_isolates_test.dart (right):

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
tests/html/dom_isolates_test.dart:39:
spawnDomFunction(childDomIsolate).then(expectAsync1(
Sorry, I believe the main thing is we should not leave test callback before
expectAsync1 is invoked and that should be exactly the case:

spawnDomFunction returns immediately providing a future, now arguments of then
are evaluated leading to async callback registration, correct?

On 2013/04/01 14:07:18, vsm wrote:
> I think expectAsync1 needs to be at the top-level to be effective.  E.g.,
> 
> final callback = expectAsync1(...);
> spawnDomFunction(childDomIsolate).then(callback);

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
File tests/html/dom_isolates_test.dart.child_isolate.dart (right):

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
tests/html/dom_isolates_test.dart.child_isolate.dart:1: import 'dart:html';
On 2013/04/01 14:07:18, vsm wrote:
> Standard copyright message?

Done.

https://chromiumcodereview.appspot.com/13144014/diff/1/tools/dom/src/native_D...
File tools/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/13144014/diff/1/tools/dom/src/native_D...
tools/dom/src/native_DOMImplementation.dart:62: static void
spawnDomFunction(Function f, int replyTo) native "Utils_spawnDomFunction";
On 2013/04/01 14:07:18, vsm wrote:
> Does f no longer need to be a top-level function?

No, it needs to be, but I'd like to keep line shorter.

[vsm, 2013-04-01 14:25:30]

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
File tests/html/dom_isolates_test.dart (right):

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
tests/html/dom_isolates_test.dart:39:
spawnDomFunction(childDomIsolate).then(expectAsync1(
I'm worried about the ordering:

(1) Test starts.
(2) spawnDomFunction executes, producing Future.
(3) Test completes and passes as no callbacks are yet expected.
(4) then clause executes, registering the expectAsync1 too late.

Isn't that a legal ordering as this test is written?

On 2013/04/01 14:18:17, Anton Muhin wrote:
> Sorry, I believe the main thing is we should not leave test callback before
> expectAsync1 is invoked and that should be exactly the case:
> 
> spawnDomFunction returns immediately providing a future, now arguments of then
> are evaluated leading to async callback registration, correct?
> 
> On 2013/04/01 14:07:18, vsm wrote:
> > I think expectAsync1 needs to be at the top-level to be effective.  E.g.,
> > 
> > final callback = expectAsync1(...);
> > spawnDomFunction(childDomIsolate).then(callback);
>

[Anton Muhin, 2013-04-01 14:46:24]

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
File tests/html/dom_isolates_test.dart (right):

https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
tests/html/dom_isolates_test.dart:39:
spawnDomFunction(childDomIsolate).then(expectAsync1(
On 2013/04/01 14:25:30, vsm wrote:
> I'm worried about the ordering:
> 
> (1) Test starts.
> (2) spawnDomFunction executes, producing Future.
> (3) Test completes and passes as no callbacks are yet expected.
> (4) then clause executes, registering the expectAsync1 too late.
> 
> Isn't that a legal ordering as this test is written?

I believe no. spawnDomFunction indeed produces a future, but doesn't stop here
and immediately invokes .then on it.  As part of .then invocation its arguments
are evaluated and closure is registered leading to marking the test as
asynchronous.

> 
> On 2013/04/01 14:18:17, Anton Muhin wrote:
> > Sorry, I believe the main thing is we should not leave test callback before
> > expectAsync1 is invoked and that should be exactly the case:
> > 
> > spawnDomFunction returns immediately providing a future, now arguments of
then
> > are evaluated leading to async callback registration, correct?
> > 
> > On 2013/04/01 14:07:18, vsm wrote:
> > > I think expectAsync1 needs to be at the top-level to be effective.  E.g.,
> > > 
> > > final callback = expectAsync1(...);
> > > spawnDomFunction(childDomIsolate).then(callback);
> > 
>

[vsm, 2013-04-01 15:40:07]

Yes - you're right.  LGTM.

On 2013/04/01 14:46:24, Anton Muhin wrote:
>
https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
> File tests/html/dom_isolates_test.dart (right):
> 
>
https://chromiumcodereview.appspot.com/13144014/diff/1/tests/html/dom_isolate...
> tests/html/dom_isolates_test.dart:39:
> spawnDomFunction(childDomIsolate).then(expectAsync1(
> On 2013/04/01 14:25:30, vsm wrote:
> > I'm worried about the ordering:
> > 
> > (1) Test starts.
> > (2) spawnDomFunction executes, producing Future.
> > (3) Test completes and passes as no callbacks are yet expected.
> > (4) then clause executes, registering the expectAsync1 too late.
> > 
> > Isn't that a legal ordering as this test is written?
> 
> I believe no. spawnDomFunction indeed produces a future, but doesn't stop here
> and immediately invokes .then on it.  As part of .then invocation its
arguments
> are evaluated and closure is registered leading to marking the test as
> asynchronous.
> 
> > 
> > On 2013/04/01 14:18:17, Anton Muhin wrote:
> > > Sorry, I believe the main thing is we should not leave test callback
before
> > > expectAsync1 is invoked and that should be exactly the case:
> > > 
> > > spawnDomFunction returns immediately providing a future, now arguments of
> then
> > > are evaluated leading to async callback registration, correct?
> > > 
> > > On 2013/04/01 14:07:18, vsm wrote:
> > > > I think expectAsync1 needs to be at the top-level to be effective. 
E.g.,
> > > > 
> > > > final callback = expectAsync1(...);
> > > > spawnDomFunction(childDomIsolate).then(callback);
> > > 
> >

[Anton Muhin, 2013-04-02 12:48:47]

Committed patchset #2 manually as r20776 (presubmit successful).