Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1314143002: VM: Don't depend on unoptimized code when inlining and creating deoptimization info. (Closed)

Created:
5 years, 3 months ago by Florian Schneider
Modified:
5 years, 3 months ago
Reviewers:
srdjan, siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Don't depend on unoptimized code when inlining and creating deoptimization info. This is the first of two steps of removing the requirement to have unoptimized code when optimizing a function. This would allow optimizing a function without generating unoptimized code first. The only remaining dependency is block reordering (BlockScheduler::AssignWeights) since the edge counters are currently found in the PC descriptors array associated with unoptimized code. BUG= R=asiva@google.com, iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/bad2786f6cb85bfe5fe189a3a972705163a239fa

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -62 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Florian Schneider
5 years, 3 months ago (2015-08-26 11:10:09 UTC) #2
srdjan
DBC https://codereview.chromium.org/1314143002/diff/1/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/1314143002/diff/1/runtime/vm/flow_graph_compiler.cc#newcode392 runtime/vm/flow_graph_compiler.cc:392: const Script& script = Script::Handle(instr->env()->function().script()); zone() (and below ...
5 years, 3 months ago (2015-08-26 15:43:48 UTC) #4
siva
lgtm
5 years, 3 months ago (2015-08-26 17:34:10 UTC) #5
Ivan Posva
LGTM -ip
5 years, 3 months ago (2015-08-26 19:29:10 UTC) #6
Florian Schneider
https://codereview.chromium.org/1314143002/diff/1/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/1314143002/diff/1/runtime/vm/flow_graph_compiler.cc#newcode392 runtime/vm/flow_graph_compiler.cc:392: const Script& script = Script::Handle(instr->env()->function().script()); On 2015/08/26 15:43:48, srdjan ...
5 years, 3 months ago (2015-08-27 09:32:31 UTC) #7
Florian Schneider
5 years, 3 months ago (2015-08-27 09:32:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bad2786f6cb85bfe5fe189a3a972705163a239fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698