Remove support for 'dart:scalarlist' in the Dart VM.

Remove support for 'dart:scalarlist' in the Dart VM.
Committed: https://code.google.com/p/dart/source/detail?r=20680

[Ivan Posva, 2013-03-29 00:42:22]

LGTMwC

-Ivan

https://codereview.chromium.org/13139002/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/13139002/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:2178: if (array.ElementSizeInBytes() == 1) {
So it is not possible to get the byte sized chunks out of say a Int16List, but
it is possible to get the truncated values out of a List of Smis?

https://codereview.chromium.org/13139002/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:2188: }
Why did you go away from the if-else if-else if-else?

https://codereview.chromium.org/13139002/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:2271: if (array.ElementSizeInBytes() == 1) {
ditto

[siva, 2013-03-29 18:02:33]

https://codereview.chromium.org/13139002/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/13139002/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:2178: if (array.ElementSizeInBytes() == 1) {
This code of getting truncated values out of a List of Smis below is a hack that
was added early on when socket read/write was happening using these lists. I
don't think we need it anymore. I would suggest we remove it so that we don't
have this kind of weird truncated access.

I will probably remove it in a different CL.

On 2013/03/29 00:42:22, Ivan Posva wrote:
> So it is not possible to get the byte sized chunks out of say a Int16List, but
> it is possible to get the truncated values out of a List of Smis?

https://codereview.chromium.org/13139002/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:2188: }
I had to do it above because of the fall through in the TypedData case above
when the element size in bytes in not 1.

On 2013/03/29 00:42:22, Ivan Posva wrote:
> Why did you go away from the if-else if-else if-else?

https://codereview.chromium.org/13139002/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:2271: if (array.ElementSizeInBytes() == 1) {
I had to do it above because of the fall through in the TypedData case above
when the element size in bytes in not 1.


On 2013/03/29 00:42:22, Ivan Posva wrote:
> ditto

[siva, 2013-03-29 18:34:05]

Committed patchset #1 manually as r20680 (presubmit successful).