Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131373002: Fix listing of '' and '/'. (Closed)

Created:
6 years, 11 months ago by Anders Johnsen
Modified:
6 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix listing of '' and '/'. BUG=https://code.google.com/p/dart/issues/detail?id=15966 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31652

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -18 lines) Patch
M runtime/bin/directory_android.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M runtime/bin/directory_linux.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M runtime/bin/directory_macos.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M runtime/bin/directory_win.cc View 2 chunks +7 lines, -1 line 0 comments Download
M sdk/lib/io/directory_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/file_system_entity.dart View 1 chunk +16 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
6 years, 11 months ago (2014-01-09 10:15:21 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/131373002/diff/1/sdk/lib/io/file_system_entity.dart File sdk/lib/io/file_system_entity.dart (right): https://codereview.chromium.org/131373002/diff/1/sdk/lib/io/file_system_entity.dart#newcode609 sdk/lib/io/file_system_entity.dart:609: static String _trimTrailingPathSeparators(String path) { Is this method ...
6 years, 11 months ago (2014-01-09 10:33:10 UTC) #2
Anders Johnsen
https://codereview.chromium.org/131373002/diff/1/sdk/lib/io/file_system_entity.dart File sdk/lib/io/file_system_entity.dart (right): https://codereview.chromium.org/131373002/diff/1/sdk/lib/io/file_system_entity.dart#newcode609 sdk/lib/io/file_system_entity.dart:609: static String _trimTrailingPathSeparators(String path) { On 2014/01/09 10:33:10, Søren ...
6 years, 11 months ago (2014-01-09 10:33:38 UTC) #3
Anders Johnsen
6 years, 11 months ago (2014-01-09 10:34:06 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r31652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698